Hi Kumar, On Mon, 2 Aug 2010 12:21:22 -0500 Kumar Gala <ga...@kernel.crashing.org> wrote: > > --- a/arch/powerpc/include/asm/dma-mapping.h > +++ b/arch/powerpc/include/asm/dma-mapping.h > @@ -131,9 +131,7 @@ static inline int dma_set_mask(struct device *dev, u64 > dma_mask) > { > struct dma_map_ops *dma_ops = get_dma_ops(dev); > > - if (unlikely(dma_ops == NULL)) > - return -EIO; > - if (dma_ops->set_dma_mask != NULL) > + if (unlikely(dma_ops == NULL) && (dma_ops->set_dma_mask != NULL))
The first part of this condition is backward (should be != (or just "dma_ops") (and "likely"?)). -- Stephen Rothwell <s...@canb.auug.org.au>
pgpMYfPgjNIiF.pgp
Description: PGP signature
_______________________________________________ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev