On Thu, 22 Jul 2010 23:03:03 +0400 Dmitry Eremin-Solenikov <dbarysh...@gmail.com> wrote:
> Hello, > > On Thu, Jul 22, 2010 at 10:40 PM, Kumar Gala <ga...@kernel.crashing.org> > wrote: > > > > On Jul 22, 2010, at 1:25 PM, Scott Wood wrote: > >> How about keeping the error stuff as a separate device from Linux's > >> perspective, but have the main Freescale PCI code create it as a > >> platform device instead of putting it in the device tree? > > > > I'd be good with that solution. > > Then we come back to the question that was raised before (during initial > review of edac driver): as PCI code is probbed long before other parts > of the kernel and mpc85xx_edac code can be compiled as module, > it's not possible to directly call mpc85xx_edac code from fsl_pci.c Right, that's why I suggested creating a platform device rather than just a function call. > Two initial suggestions were: > 1) creating special platform device > 2) creating special of_platform device from dts > > Which approach should I choose? Did i miss any other opportunities? #1, as it keeps the split out of the device tree. Besides the theoretical/aesthetic issues of putting Linux implementation concerns into the device tree, #2 would mean that the edac driver wouldn't work when Linux is booted with an old device tree. -Scott _______________________________________________ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev
