Sandeep,

I believe you are the author of the code that adds multiple queue and
multiple group support to the Gianfar driver.  Can you update
Documentation/powerpc/dts-bindings/fsl/tsec.txt with the binding
documentation for these nodes, so that we can all know what they're supposed
to look like?

Kim Phillips wrote:

>> +            enet0: ether...@b0000 {
>> +                    queue-gr...@0{
>> +                            #address-cells = <1>;
>> +                            #size-cells = <1>;
>> +                            reg = <0xB0000 0x1000>;
>> +                            fsl,rx-err-int-map = <0xAA>;
>> +                            fsl,tx-int-map = <0xAA>;
>> +                            interrupts = <29 2 30 2 34 2>;
>> +                    };
>> +                    queue-gr...@1{
>> +                            #address-cells = <1>;
>> +                            #size-cells = <1>;
>> +                            reg = <0xB4000 0x1000>;
>> +                            fsl,rx-err-int-map = <0x55>;
>> +                            fsl,tx-int-map = <0x55>;
>> +                            interrupts = <17 2 18 2 24 2>;
>> +                    };
>> +            };
>> +
>> +            enet1: ether...@b1000 {
> 
>> +                    queue-gr...@0{
>> +                            #address-cells = <1>;
>> +                            #size-cells = <1>;
>> +                            reg = <0xB1000 0x1000>;
>> +                            fsl,rx-err-int-map = <0xAA>;
>> +                            fsl,tx-int-map = <0xAA>;
>> +                            interrupts = <35 2 36 2 40 2>;
>> +                    };
>> +                    queue-gr...@1{
>> +                            #address-cells = <1>;
>> +                            #size-cells = <1>;
>> +                            reg = <0xB5000 0x1000>;
>> +                            fsl,rx-err-int-map = <0x55>;
>> +                            fsl,tx-int-map = <0x55>;
>> +                            interrupts = <51 2 52 2 67 2>;
>> +                    };
> 
> these queue-group nodes, fsl,{r,t}x-* properties...
> 
>> +            cry...@30000 {
> 
>> +                    fsl,multi-host-mode = "dual";
>> +                    fsl,channel-remap = <0x3>;
> 
> and the above two properties aren't supported by their respective
> drivers, nor are they listed in the dts bindings documentation.
> 
> Kim

_______________________________________________
Linuxppc-dev mailing list
Linuxppc-dev@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/linuxppc-dev

Reply via email to