On Wed, Jun 16, 2010 at 4:05 AM, Richard Cochran <richardcoch...@gmail.com> wrote: > On Tue, Jun 15, 2010 at 12:49:13PM -0600, Grant Likely wrote: >> Won't this break things for existing DP83640 users? > > Nope, the driver was only added five patches ago, and it only offers > the timestamping stuff. The standard PHY functions just call the > generic functions, so the PHY works fine even without this driver. > >> > +static struct ptp_clock *dp83640_clock; >> > +DEFINE_SPINLOCK(clock_lock); /* protects the one and only dp83640_clock */ >> >> Why only one? Is it not possible to have 2 of these PHYs in a system? > > Yes, you can have multiple PHYs, but only one PTP clock. > > If you do use multiple PHYs, then you must wire their clocks together > and adjust the PTP clock on only one of the PHYs. > > > Thanks for your other comments,
You're welcome. Make sure to cc: linux-kernel on your next posting. I commented on what I could, but there is a lot of code outside my areas of expertise. In particular the time keeping code needs to be looked at by the maintainers in that area. Cheers, g. _______________________________________________ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev
