> You just introduced an unnamed structure of device + resources, > it isn't declared anywhere but in the code itself (either via > &foo[1] or buf + sizeof(*foo)). > > You're not the only one who hacks (or at least have to > understand) the OF stuff, so let's try keep this stuff > readable? > > I told you several ways of how to improve the code (based on > the ideas from drivers/base/, so the ideas aren't even mine, > fwiw).
I tend to agree with Anton here. BTW. Why not make of_device a wrapper (or even alias of) platform_device ? :-) That way you get the resource array etc.. for free and it will make the whole of_device vs. platform_device issue moot. Cheers, Ben. _______________________________________________ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev