On Fri, 4 Jun 2010, Esben Haabendal wrote: NAK for various reasons (no particular order):
1) That patch misses a sensible changelog. See Documentation/Submit* 2) patch contains several independent changes, which need to be separated > @@ -120,6 +124,10 @@ static int pca953x_gpio_direction_input(struct gpio_chip > *gc, unsigned off) > chip = container_of(gc, struct pca953x_chip, gpio_chip); > > reg_val = chip->reg_direction | (1u << off); > + > + if (reg_val == chip->reg_direction) > + return 0; > + This is an optimization of its own value. 3) it breaks the driver. See http://lkml.org/lkml/2010/6/6/177 for a detailed explanation 4) the virq/powerpc churn is horrible and I bet there are sane ways to solve this, but it leave this to the powerpc experts. Thanks, tglx _______________________________________________ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev
