Hi Sean: I will withdraw this patch. I had a talk with the U-Boot guys. The reason for this patch was to support those guys that had their ECC ordering at (213) on the older version of the kernel. Upgrading to (123) may be problematic. Since without a jtag it would be a bit complex. I still think this NAND_ECC_SMC define is somewhat missleading. Given that both 1-2-3 and 2-1-3 are supported by the correction routine. Feng
________________________________ From: Sean MacLennan [mailto:[email protected]] Sent: Sat 2/20/2010 5:11 PM To: Feng Kan Cc: [email protected]; [email protected]; Feng Kan Subject: Re: [PATCH 1/1] NDFC: add support for alternate ECC format for ndfc On Thu, 18 Feb 2010 15:11:18 -0800 Feng Kan <[email protected]> wrote: > This is to lock down the ordering in the correction routine against > the calculate routine. Otherwise, incorrect define would cause ECC > errors. Did you actually find a 44x PPC core that is not NAND_ECC_SMS format? Cheers, Sean
_______________________________________________ Linuxppc-dev mailing list [email protected] https://lists.ozlabs.org/listinfo/linuxppc-dev
