On Tue, Feb 2, 2010 at 12:47 AM, Anatolij Gustschin <ag...@denx.de> wrote:
> Currently the support for MPC5121 PSC UART in the mpc52xx_uart
> driver is broken (only console pre-initialized by the bootloader
> works). Re-enable it now by providing MPC5121 specific ops
> for PSCx clock activation, FIFO controller init/uninit and
> MPC5121 PSC FIFO shared interrupt handling functions.
>
> Signed-off-by: Anatolij Gustschin <ag...@denx.de>
> Cc: Grant Likely <grant.lik...@secretlab.ca>
> ---
> This patch has been tested using 5200/5121 multiplatform kernel
> on tqm5200 and mpc5121ads boards (mpc52xx_uart staticaly linked
> and as a driver module).
>
> @@ -1164,7 +1378,8 @@ mpc52xx_uart_of_probe(struct of_device *op, const
> struct of_device_id *match)
> /* Add the port to the uart sub-system */
> ret = uart_add_one_port(&mpc52xx_uart_driver, port);
> if (ret) {
> - irq_dispose_mapping(port->irq);
> + if (!(port->irqflags & IRQF_SHARED))
> + irq_dispose_mapping(port->irq);
I'd just drop the irq_dispose_mapping() entirely. It doesn't really
cost anything to leave the mapping around when unloading the driver.
Otherwise, looks good to me. You can add my acked-by in the next spin.
g.
_______________________________________________
Linuxppc-dev mailing list
Linuxppc-dev@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/linuxppc-dev
