On Wed, Jan 13, 2010 at 7:07 PM, Benjamin Herrenschmidt <b...@kernel.crashing.org> wrote: > On Wed, 2010-01-13 at 16:23 +0100, Michal Simek wrote: > >> The main problems are: >> ppc use ppc_md struct which we don't have it on Microblaze. >> xilinx-pci driver uses exclude_device function. This function is used in >> indirect_pci.c too. There could be a way to move that function directly >> to pci_controller structure which could be useful for other controllers >> too. What do you think? >> >> Then there are some other ppc_md. calling like pcibios_after_init which >> if I see correctly not used for ppc too. > > We may not be using after_init() anymore in which case you are welcome > to send a patch to remove it :-) > > As for the others, well ... maybe you can do wrappers for these that > call into ppc_md. on powerpc and into some kind of arch_pci_ops. that > the platform provides on microblaze ?
I agree. Replace the direct ppc_md. references with arch-provided wrappers. >> Files contains CONFIG_PPC_OF and we would like to use only CONFIG_OF. >> I remember any discuss around but not sure what was the conclusion on >> powerpc. > > I think that should be allright, Grant, any objection there ? None whatsoever. >> Part of headers are the same that's why there will be a space to move >> them to asm-generic. > > If you can convince other archs that it makes sense to do so ? :-) Arnd can give you good advice here I think. Cheers, g. -- Grant Likely, B.Sc., P.Eng. Secret Lab Technologies Ltd. _______________________________________________ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev
