> Ok, here's the fix. It's not the _right_ fix, but it Works For Me (tm) and
> I'll
> leave it to you guys to figure out what this _means_:
I've failed to reproduce so far on both a Wallstreet powerbook (similar
generation and chipset as your beige G3) and a G5 with an added serial
port using current upstream...
Can you verify it's still there ? I might be able to reproduce on a
Beige G3 as well next week.
Cheers,
Ben.
> Signed-off-by: Rob Landley <r...@landley.net>
>
> diff -ru build/packages/linux/drivers/serial/serial_core.c
> build/packages/linux2/drivers/serial/serial_core.c
> --- build/packages/linux/drivers/serial/serial_core.c 2009-12-02
> 21:51:21.000000000 -0600
> +++ build/packages/linux2/drivers/serial/serial_core.c 2009-12-08
> 06:17:06.000000000 -0600
> @@ -113,7 +113,7 @@
> static void uart_tasklet_action(unsigned long data)
> {
> struct uart_state *state = (struct uart_state *)data;
> - tty_wakeup(state->port.tty);
> + if (state->port.tty) tty_wakeup(state->port.tty);
> }
>
> static inline void
>
> That one line workaround makes the panic go away, and things seem to work
> fine from there.
>
> I note that pmac_zilog.c function pmz_receiv_chars() has the following chunk:
>
> /* Sanity check, make sure the old bug is no longer happening */
> if (uap->port.state == NULL || uap->port.state->port.tty == NULL) {
> WARN_ON(1);
> (void)read_zsdata(uap);
> return NULL;
> }
>
> Which doesn't catch this because it's the write code path (not the read code
> path) that's running into
> this.
>
> Rob
_______________________________________________
Linuxppc-dev mailing list
Linuxppc-dev@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/linuxppc-dev
