+#ifdef CONFIG_PPC_EARLY_DEBUG_USBGECKO +setup_usbgecko_bat: + /* prepare a BAT for early io */ +#if defined(CONFIG_GAMECUBE) + lis r8, 0x0c00 +#elif defined(CONFIG_WII) + lis r8, 0x0d00 +#else +#error Invalid platform for USB Gecko based early debugging. +#endif
A kernel with both CONFIG_WII and CONFIG_GAMECUBE works fine on either, right? If so, could you please switch the two #ifs? A dual-platform kernel will be used on a Wii much more likely than on a GC.
+ /* + * The virtual address used must match the virtual address + * associated to the fixmap entry FIX_EARLY_DEBUG_BASE. + */ + lis r11, 0xfffe /* top 128K */ + ori r8, r8, 0x002a /* uncached, guarded ,rw */ + ori r11, r11, 0x3 /* 128K */
I think you should clear Vp since the BAT mapping can survive until after user space is started; it won't hurt to remove it either way. So 2 instead of 3. And put the meaning in the comment :-) Looks fine otherwise. Segher _______________________________________________ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev
