On Tue, 2009-12-01 at 06:23 +0100, Albert Herranz wrote: > Richard Holden wrote: > >> diff --git a/arch/powerpc/platforms/embedded6xx/usbgecko_udbg.c > >> b/arch/powerpc/platforms/embedded6xx/usbgecko_udbg.c > >> index ba4c7cc..3f125b6 100644 > >> --- a/arch/powerpc/platforms/embedded6xx/usbgecko_udbg.c > >> +++ b/arch/powerpc/platforms/embedded6xx/usbgecko_udbg.c > >> @@ -17,6 +17,7 @@ > >> #include <asm/io.h> > >> #include <asm/prom.h> > >> #include <asm/udbg.h> > >> +#include <asm/fixmap.h> > >> > >> #include "usbgecko_udbg.h" > >> > >> @@ -270,3 +271,61 @@ done: > >> of_node_put(np); > >> return; > >> } > >> + > >> +#ifdef CONFIG_PPC_EARLY_DEBUG_USBGECKO > >> + > >> +static void __init ug_early_remap(void) > > > > you may want to rename the ug_ prefix, it took me a while looking back > > and forth through the patch to convince myself it wasn't a typo. > > > > What's wrong with ug_ ? (ug = (u)sb(g)ecko)
What's wrong with usb_gecko_early_remap() :) cheers
signature.asc
Description: This is a digitally signed message part
_______________________________________________ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev
