+                       xfb-start = <0x01698000>; /* end-of-ram - xfb-size */
+                       xfb-size = <0x168000>;

XFB address isn't fixed on the hardware, and the kernel might
want to move it, and you can easily probe for it anyway.  Remove
these last two properties please.

Ok but you need to know what it was setup to by the FW no ? To avoid
having a temporary display "glitch" while booting... Also on a 24M
config,it might get tough for the driver to allocate 2M contiguous like
that if it's done late in the boot process.

Sure, the platform code will have to probe this very early.  Can always
do the /memreserve/ if really needed.

+               aux...@0c005000 {
+                       compatible = "nintendo,flipper-auxram";
+                       reg = <0x0c005000 0x200>; /* DSP */
+                       interrupts = <6>;
+                       interrupt-parent = <&pic>;
+               };
+
+               au...@0c005000 {
+                       compatible = "nintendo,flipper-audio";
+                       reg = <0x0c005000 0x200              /* DSP */
+                              0x0c006c00 0x20>;     /* AI */
+                       interrupts = <6>;
+                       interrupt-parent = <&pic>;
+               };

These two have the same address, not good.  Just remove the
auxram node?

Or make it a child of audio ? :-)

Hrm, actually, DSP and AI should be separate nodes, and ARAM a child
of DSP (on its own bus, so it can show that it is 16MB etc.)


Segher

_______________________________________________
Linuxppc-dev mailing list
Linuxppc-dev@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/linuxppc-dev

Reply via email to