On Tue, Nov 17, 2009 at 8:42 AM, Dmitry Eremin-Solenikov <dbarysh...@gmail.com> wrote: > This patch improves OF GPIO bindings so, that most non-OF-specific gpio > controllers don't need to call any of OF binding function: > > 0) Move of_gpio_chip into main gpio_chip structure. > 1) Call of_gpio_init/destroy from gpiochip_add/remove. > 2) By default supply reasonable defaults for gpio_cells/xlate
I think this change approaches the problem from the wrong way around. It is not appropriate to try and build OF hooks into gpiolib. gpiolib should be completely agnostic to any layers around them used to get data about how they are configured up. If anything, OF helpers should wrap around the gpiolib functions so that drivers can use them if it is useful to do so. g. _______________________________________________ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev
