> -----Original Message----- > From: Anton Vorontsov [mailto:avoront...@ru.mvista.com] > Sent: Wednesday, September 23, 2009 8:00 PM > To: Gao Guanhua-B22826 > Cc: sdhci-de...@lists.ossman.eu; linuxppc-...@ozlabs.org > Subject: Re: [PATCH 6/6] P2020DS: Remove sdhci-dma-broken and > sdhci-ahb2mag-irq-bypass properties > > On Wed, Sep 23, 2009 at 05:08:12PM +0800, Gao Guanhua wrote: > > The SDHC on P2020DS board use DMA mode by default. > > This patch remove the properties used in PIO mode. > > You just added the properties in 3/6 and 4/6, and now you > instantly remove them?
Add them to support the PIO mode, the board has a hardware bug, sdhc can only work in PIO mode. Then the bug has been fixed. So remove those properties. Yes, maybe I shouldnot add the property in the dts, and only support PIO in driver. Thanks. > > > --- > > arch/powerpc/boot/dts/p2020ds.dts | 2 -- > > 1 files changed, 0 insertions(+), 2 deletions(-) > > > > diff --git a/arch/powerpc/boot/dts/p2020ds.dts > > b/arch/powerpc/boot/dts/p2020ds.dts > > index 29989fb..3263397 100644 > > --- a/arch/powerpc/boot/dts/p2020ds.dts > > +++ b/arch/powerpc/boot/dts/p2020ds.dts > > @@ -459,8 +459,6 @@ > > reg = <0x2e000 0x1000>; > > interrupts = <72 0x2>; > > interrupt-parent = <&mpic>; > > - fsl,sdhci-dma-broken; > > - fsl,sdhci-ahb2mag-irq-bypass; > > fsl,sdhci-adjust-timeout; > > clock-frequency = <0>; > > }; > > -- > > 1.6.4 > > -- > Anton Vorontsov > email: cbouatmai...@gmail.com > irc://irc.freenode.net/bd2 > > _______________________________________________ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev
