On Thu, Aug 13, 2009 at 07:34:07AM +1000, Benjamin Herrenschmidt wrote: > On Wed, 2009-08-12 at 13:35 +0100, Mark Brown wrote:
> > What happens if another clock gets added or the list gets reordered for > > some reason? > The device-tree is mostly static in that regard. I'm not sure what you > mean. Clocks are referenced by IDs so if you want to add more clocks you > can just add them to the end. The "NULL" case is typically for things > that have only one clock (which seems to be reasonably common in ARM > land). The issue I'm worrying about here is what happens if the device has only one clock in current revisions of the hardware but another revision of the same hardware is produced which adds another clock. When that happens your NULL lookup gets confused. > I think it's reasonable to ask whoever produces the device-tree to keep > the two properties in sync. It's not just the device tree, it's also the drivers which have to be able to cope with whatever random device tree that's thrown at them. This is less of a problem on ARM where it's fairly straightforward to adjust the users at the same time as the driver but if you've got a device tree delivered via a completely different distribution mechanism it gets more sticky. > > Note that the present ARM implementations don't handle anything except > > the core SoC normally. > Ok, interesting. I don't see why the API would prevent going further > tho. In any case, that isn't a big deal, at least until somebody proves > me wrong, I believe what I proposed remains simple enough and leaves > enough to the actual implementations to allow pretty much anything in > that area. The problem with the API at the minute in this regard is that there is no standard way of registering new clocks. Only something that knows about the magic sauce for a given architecture (if any) is able to add clocks. My concern here is that if PowerPC moves in this direction without some general agreement from elsewhere then there may be problems for drivers. _______________________________________________ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev
