On Fri, Aug 07, 2009 at 06:08:59PM +0100, David Vrabel wrote: > Anton Vorontsov wrote: > > eSDHC fails to recognize some SDHS cards, throwing timeout errors: > > > > mmc0: error -110 whilst initialising SD card > > > > That's because we calculate timeout value in a wrong way: on eSDHC > > hosts the timeout clock is derivied from the SD clock, which is set > > dynamically. > > I've seen an reference design for an SDHC controller do this also.
Thanks for the information! > > +/* Controller has dynamic timeout clock management */ > > +#define SDHCI_QUIRK_DYNAMIC_TIMEOUT_CLOCK (1<<24) > > This comment and define would be better if it matched terms used in the > spec. Suggest: > > /* Controller uses SDCLK instead of TMCLK for data timeouts. */ > #define SDHCI_QUIRK_DATA_TIMEOUT_USES_SDCLK (1 << 24) Yeah, if it's somewhat common scheme, then it makes sense to name the quirk that way. Thanks, -- Anton Vorontsov email: cbouatmai...@gmail.com irc://irc.freenode.net/bd2 _______________________________________________ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev
