Hello David,

David Gibson wrote:
> On Wed, Jul 29, 2009 at 10:32:30AM +0200, Heiko Schocher wrote:
> 
> [snip]
>> +                    m...@10d40 {
>> +                            device_type = "mdio";
> 
> Drop this device_type.

Done.

>> +                            compatible = "fsl,cpm2-mdio-bitbang";
>> +                            reg = <0x10d00 0x14>;
>> +                            #address-cells = <1>;
>> +                            #size-cells = <0>;
>> +                            fsl,mdio-pin = <12>;
>> +                            fsl,mdc-pin = <13>;
>> +
>> +                            phy0: ethernet-...@0 {
>> +                                    reg = <0x0>;
>> +                                    device_type = "ethernet-phy";
> 
> And this one, too.

Done.

>> +                            };
>> +
>> +                            phy1: ethernet-...@1 {
>> +                                    reg = <0x1>;
>> +                                    device_type = "ethernet-phy";
>> +                            };
>> +                    };
> 

I collect more comments, then the patch follows.
Thanks
bye
Heiko
-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
_______________________________________________
Linuxppc-dev mailing list
Linuxppc-dev@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/linuxppc-dev

Reply via email to