On Mon, 27 Jul 2009 16:08:46 -0500 Becky Bruce <bec...@kernel.crashing.org> wrote:
> > On Jul 23, 2009, at 10:24 PM, FUJITA Tomonori wrote: > > > Signed-off-by: FUJITA Tomonori <fujita.tomon...@lab.ntt.co.jp> > > Fujita, > > Since you're removing all the uses of it, you should probably remove > PPC_NEED_DMA_SYNC_OPS from arch/powerpc/Kconfig: > > diff --git a/arch/powerpc/Kconfig b/arch/powerpc/Kconfig > index 0603b6c..fb3f4ff 100644 > --- a/arch/powerpc/Kconfig > +++ b/arch/powerpc/Kconfig > @@ -307,10 +307,6 @@ config SWIOTLB > platforms where the size of a physical address is larger > than the bus address. Not all platforms support this. > > -config PPC_NEED_DMA_SYNC_OPS > - def_bool y > - depends on (NOT_COHERENT_CACHE || SWIOTLB) > - > config HOTPLUG_CPU > bool "Support for enabling/disabling CPUs" > depends on SMP && HOTPLUG && EXPERIMENTAL && (PPC_PSERIES || > PPC_PMAC) > > Otherwise, this looks good to me. Ah, thanks. I fold the above change. The updated patchset is available at: git://git.kernel.org/pub/scm/linux/kernel/git/tomo/linux-2.6-misc.git powerpc > I also think you want an ACK from Ben - making this switch does add > slight overhead to platforms that don't need sync ops, but I think > it's worth it. IIRC, it was Ben who asked for the optimization of > NEED_DMA_SYNC_OPS, so I'd like him to weigh in here. Yeah, of course. Ben? _______________________________________________ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev
