Dear Grant Likely, In message <fa686aa40907151017n76524708tdb028689adad4...@mail.gmail.com> you wrote: > On Wed, Jul 15, 2009 at 9:18 AM, Wolfgang Denk<w...@denx.de> wrote: > > The MII speed calculation was based on the CPU clock (ppc_proc_freq), > > but for MPC512x we must use the bus clock instead. > > > > This patch makes it use the correct clock and makes sure we don't > > clobber reserved bits in the MII_SPEED register. ... > Drop the common code bit. The 5200 and 5121 are different devices and > it is a tiny bit of code. I don't think there is any benefit to > having it as a common function. Just roll the get_mii_speed function > in the mii-fec driver itself.
I don't like to see the code repeated - it makes maintenance harder and increases the memory footprint. But if you like it that way I'll do that. > Also, this patch can be quite a bit simpler if you use the .data > pointer in the drivers match table to specify the function used to > return the bus clock speed. Something like this: OK, will do that, too. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de Weekends were made for programming. - Karl Lehenbauer _______________________________________________ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev
