-------- Original-Nachricht -------- > Datum: Wed, 08 Jul 2009 16:13:10 +0200 > Von: Takashi Iwai <ti...@suse.de> > An: Benjamin Herrenschmidt <b...@kernel.crashing.org> > CC: Gerhard Pircher <gerhard_pirc...@gmx.net>, linuxppc-...@ozlabs.org > Betreff: Re: ALSA fixes for non-coherent ppc32 again
> At Wed, 08 Jul 2009 13:01:50 +1000, > Benjamin Herrenschmidt wrote: > > > > On Mon, 2009-06-22 at 08:34 +1000, Benjamin Herrenschmidt wrote: > > > On Sun, 2009-06-21 at 20:18 +0200, Gerhard Pircher wrote: > > > > Hi, > > > > > > > > Takashi Iwai posted patches to make ALSA work on non-coherent > > > > PPC32 systems (almost exactly) a year ago. See here: > > > > > > > > http://www.nabble.com/-PATCH-0-3--ALSA-fixes-for-non-coherent-ppc32-to17980027.html#a17980027 > > > > > > > > As far as I can see these patches never went upstream. Where > > > > there any objections or did we just forget about them? It would > > > > be cool, if the patches could be merged now, as at least two > > > > platforms need this bugfix (namely Sam440 and AmigaOne). > > > > > > I definitely forgot about those... But I'm fine with what Takashi > > > did for now, I can always make the powerpc helper for > > > dma_mmap_coherent() smarter later on if necessary. > > > > BTW. Can you guys send a "final" patch for adding mmap_coherent to > > powerpc ? Please make so that the dma_mmap_coherent() function doesn't > > explose if dma_ops->mmap_coherent is NULL though (either fail > > gracefully or fallback to some standard mmap). > > The attached is the revised patch. It falls backs to the standard > mmap. > > The whole patch series are found in test/dma-fix branch of sound git > tree below: > git://git.kernel.org/pub/scm/linux/kernel/git/tiwai/sound-2.6.git > test/dma-fix > > I had no time to play cross-build yet, so it'd be helpful if someone > can test it... > (BTW, any good minimal gcc and binutils package for kernel builds for > PPC32?) Okay, I cross-build it on a x86 machine and tested it on my AmigaOne with the VIA686 onboard sound and a Soundblaster 5.1. It worked fine after I applied the "ALSA: Fix SG-buffer DMA with non-coherent architectures" patch. Thanks! Gerhard -- Neu: GMX Doppel-FLAT mit Internet-Flatrate + Telefon-Flatrate für nur 19,99 Euro/mtl.!* http://portal.gmx.net/de/go/dsl02 _______________________________________________ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev
