On Mon, 2009-06-15 at 19:40 +1000, Benjamin Herrenschmidt wrote: > > Currently this appears to break only one of the defconfigs, chrp32. > > > > http://kisskb.ellerman.id.au/kisskb/head/1907/ > > > > And that's a legitimate error AFAICT: > > > > arch/powerpc/platforms/chrp/setup.c:378: error: the frame size of 1040 > > bytes is larger than 1024 bytes > > > > From: > > > > 367 void > > 368 chrp_event_scan(unsigned long unused) > > 369 { > > 370 unsigned char log[1024]; > > 371 int ret = 0; > > I wonder to what extent we could merge that with the pSeries > event-scan...
Yeah that occured to me, someone with a chrp machine would need to test it, do we have one? > We can have a closer look tomorrow. In any case, stack alloc for that is > indeed fishy. The obvious patch to make it static doesn't fly because it's called on every cpu via a timer, so it needs to be a per-cpu at least I think. Or borrow the pseries trick of calling it on each cpu in succession, or just borrow the pseries code. cheers
signature.asc
Description: This is a digitally signed message part
_______________________________________________ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev
