On Fri, Jun 12, 2009 at 07:27:42AM +0200, Heiko Schocher wrote:
> Hello David,
>
> David Gibson wrote:
> > On Thu, Jun 11, 2009 at 08:10:41PM +0200, Heiko Schocher wrote:
> >> The following series implements basic board support for
> >> the kmeter1 board from keymile, based on a MPC8360.
> >
> > [snip]
> >> + par...@1400 {
> >> + reg = <0x1400 0x100>;
> >> + device_type = "par_io";
> >
> > This should have a compatible value instead of a device_type value.
>
> compatible = "fsl,mpc8360-par_io"; ?
Sounds reasonable, if there isn't an existing precedent to follow.
> > [snip]
> >
> >> + num-ports = <7>;
> >> +
> >> + pio_ucc1: ucc_...@00 {
> >
> > Since these nodes have addresses, they should also have reg
> > properties. And the parent should have #address-cells and
> > #size-cells.
>
> added "#address-cells" and "#size-cells", but couldn;t find what
> I should write in a "reg" entry ... I think something like that:
>
> reg = <0x00 0x01>;
If you just want a plain index number, which is what it seems you have
here, then you'll want #address-cells = 1, #size-cells = 0 and reg
will then have one cell (i.e. 1 u32) with the index number
so subn...@0 {
reg = <0>;
}
subn...@1 {
reg = <1>;
}
Note also that it's usual for the unit addresses (that's the bits
after the @ sign) to be formatted without leading zeroes.
>
> ?
>
> > [snip]
> >> + q...@100000 {
> >> + #address-cells = <1>;
> >> + #size-cells = <1>;
> >> + device_type = "qe";
> >
> > This device_type should not be here.
>
> deleted.
Ok.
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
_______________________________________________
Linuxppc-dev mailing list
Linuxppc-dev@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/linuxppc-dev
