Hi Ling, >On Thu, 2009-06-04 at 19:02 +0530, Subrata Modak wrote: >CC [M] drivers/net/ucc_geth.o > drivers/net/ucc_geth.c: In function bucc_geth_probeb: > drivers/net/ucc_geth.c:3822: error: 'ph' undeclared (first use in this > function) > drivers/net/ucc_geth.c:3822: error: (Each undeclared identifier is reported > only once > drivers/net/ucc_geth.c:3822: error: for each function it appears in.) > drivers/net/ucc_geth.c:3832: error: 'mdio' undeclared (first use in this > function) > make[2]: *** [drivers/net/ucc_geth.o] Error 1
With the above build error reported on 4th June linux next tree, i am proposing the following patch. Can you please let me know if you would like to merge it. Reference: http://lkml.org/lkml/2009/6/4/241, Fix the following build error: drivers/net/ucc_geth.c: In function bucc_geth_probeb: drivers/net/ucc_geth.c:3822: error: 'ph' undeclared (first use in this function) drivers/net/ucc_geth.c:3822: error: (Each undeclared identifier is reported only once drivers/net/ucc_geth.c:3822: error: for each function it appears in.) drivers/net/ucc_geth.c:3832: error: 'mdio' undeclared (first use in this function) make[2]: *** [drivers/net/ucc_geth.o] Error 1 Signed-off-by: Subrata Modak <subr...@linux.vnet.ibm.com> --- --- linux-2.6.30-rc8/drivers/net/ucc_geth.c.orig 2009-06-10 11:58:39.000000000 -0500 +++ linux-2.6.30-rc8/drivers/net/ucc_geth.c 2009-06-10 12:37:15.000000000 -0500 @@ -3595,6 +3595,8 @@ static const struct net_device_ops ucc_g static int ucc_geth_probe(struct of_device* ofdev, const struct of_device_id *match) { + struct device_node *mdio; + phandle *ph; struct device *device = &ofdev->dev; struct device_node *np = ofdev->node; struct net_device *dev = NULL; @@ -3819,7 +3821,7 @@ static int ucc_geth_probe(struct of_devi ugeth->node = np; /* Find the TBI PHY. If it's not there, we don't support SGMII */ - ph = of_get_property(np, "tbi-handle", NULL); + ph = (phandle *)of_get_property(np, "tbi-handle", NULL); if (ph) { struct device_node *tbi = of_find_node_by_phandle(*ph); struct of_device *ofdev; --- Regards-- Subrata _______________________________________________ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev
