On Sun, May 24, 2009 at 10:33 PM, Benjamin Herrenschmidt <b...@kernel.crashing.org> wrote: > This is going to .30 if nobody hollers. I've done some testing here > and it seems to be fine, but more eyes at this stage are much welcome.
Looks okay to me; but I'm not an expert in this area. Boots fine on Xilinx Virtex 440 and MPC5200. One minor nit below. Acked-by: Grant Likely <grant.lik...@secretlab.ca> > +#ifdef CONFIG_PPC32 > + printk(KERN_INFO "Kernel virtual memory layout:\n"); > + printk(KERN_INFO " * 0x%08lx..0x%08lx : fixmap\n", > + FIXADDR_START, FIXADDR_TOP); > +#ifdef CONFIG_HIGHMEM > + printk(KERN_INFO " * 0x%08lx..0x%08lx : highmem PTEs\n", > + PKMAP_BASE, PKMAP_ADDR(LAST_PKMAP)); > +#endif /* CONFIG_HIGHMEM */ > +#ifdef CONFIG_NOT_COHERENT_CACHE > + printk(KERN_INFO " * 0x%08lx..0x%08lx : consistent mem\n", > + IOREMAP_TOP, IOREMAP_TOP + CONFIG_CONSISTENT_SIZE); > +#endif /* CONFIG_NOT_COHERENT_CACHE */ > + printk(KERN_INFO " * 0x%08lx..0x%08lx : early ioremap\n", > + ioremap_bot, IOREMAP_TOP); > + printk(KERN_INFO " * 0x%08lx..0x%08lx : vmalloc & ioremap\n", > + VMALLOC_START, VMALLOC_END); > +#endif /* CONFIG_PPC32 */ NIT: pr_info(). Same goes for other printk's in this patch. It would also be nice for comprehension if the file move and the modification were separate commits. As it is I had to generate the diff manually, but I'm not concerned. g. -- Grant Likely, B.Sc., P.Eng. Secret Lab Technologies Ltd. _______________________________________________ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev
