From: Rogério Brito <rbr...@ime.usp.br>
Date: Sun, 3 May 2009 08:48:20 -0300
> I hope that this version is a slightly better fix to convert mace to
> netdev_ops.
>
> This is against this morning's net-2.6 tree.
>
> Signed-off-by: Rogério Brito <rbr...@ime.usp.br>
I'll apply this, thanks! I made one change however.
> @@ -798,6 +807,13 @@ static irqreturn_t mace_interrupt(int irq, void *dev_id)
> return IRQ_HANDLED;
> }
>
> +/*
> + * In the following, the parameter "data" is treated like a pointer,
> + * which is probably OK for 32 bit arches, but not for 64.
> + *
> + * (Are mace's found on any newer machines??) -- rbrito
> + *
> + */
> static void mace_tx_timeout(unsigned long data)
> {
> struct net_device *dev = (struct net_device *) data;
I left this new comment out, as this is a common idiom (passing opaque
data as an 'unsigned long' argument to a callback) and casting it to a
pointer.
It also works perfectly fine on all 32-bit and 64-bit platforms.
_______________________________________________
Linuxppc-dev mailing list
Linuxppc-dev@ozlabs.org
https://ozlabs.org/mailman/listinfo/linuxppc-dev
