On Fri, 17 Apr 2009 20:12:50 -0700 (PDT) "Trent Piepho" <xy...@speakeasy.org> wrote:
> On Mon, 6 Apr 2009, Sean MacLennan wrote: > > Now that leds-gpio is a proper OF platform driver, the Warp can use > > the leds-gpio driver rather than the old out-of-kernel driver. > > > > One side-effect is the leds-gpio driver always turns the leds off > > while the old driver left them alone. So we have to set them back to > > the correct settings. > > Originally, I had the OF bindings support this feature, see > http://article.gmane.org/gmane.linux.kernel/749094 > > Maybe this would be a better way to do it? It avoids the glitch in > the leds, is less code overall, and can be use by other devices that > might want this same behavior. Yes, that is a cleaner way to handle the LEDs. Do you know why this patch wasn't accepted at the time? A quick google shows that Grant Likely acked it. The patch will no longer apply since default state does not exist. Cheers, Sean _______________________________________________ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev
