On Apr 6, 2009, at 9:33 AM, Gary Thomas wrote:

Kumar Gala wrote:

On Apr 4, 2009, at 2:28 PM, Anton Vorontsov wrote:

With this patch we'll able to select spi_mpc83xx driver on the MPC86xx platforms. Let the driver depend on FSL_SOC, so we don't have to worry
about Kconfig anymore.

Also remove the "experimental" dependency, the driver has been tested
to work on a various hardware, and surely not experimental anymore.

Signed-off-by: Anton Vorontsov <avoront...@ru.mvista.com>
---
drivers/spi/Kconfig |   14 ++++++--------
1 files changed, 6 insertions(+), 8 deletions(-)

this looks fine, but why don't we go ahead and rename things as well?
SPI_MPC83xx -> SPI_MPC8xxx, spi_mpc83xx.c -> spi_mpc8xxx.c

mpc8xxx implies mpc82xx (e.g. mpc8272) which is not the same controller
as on the mpc83xx

True, but normally the 82xx drivers are "cpm" prefixed. I think 8xxx is at better name than 83xx.

- k
_______________________________________________
Linuxppc-dev mailing list
Linuxppc-dev@ozlabs.org
https://ozlabs.org/mailman/listinfo/linuxppc-dev

Reply via email to