On Mon, Apr 06, 2009 at 12:05:02PM +1000, Michael Ellerman wrote: > The irq remapping layer seems to cause some confusion when people > see a different irq number in /proc/interrupts vs the one they > request in their driver or DTS. > > So have the irq remapping layer print out a message when we map an > irq. The message is only printed the first time the irq is mapped, > and it's KERN_DEBUG so most people won't see it. > > Signed-off-by: Michael Ellerman <mich...@ellerman.id.au>
I like the patch in general...
> ---
> arch/powerpc/kernel/irq.c | 4 +++-
> 1 files changed, 3 insertions(+), 1 deletions(-)
>
> diff --git a/arch/powerpc/kernel/irq.c b/arch/powerpc/kernel/irq.c
> index 5576147..8c1a496 100644
> --- a/arch/powerpc/kernel/irq.c
> +++ b/arch/powerpc/kernel/irq.c
> @@ -672,11 +672,13 @@ unsigned int irq_create_mapping(struct irq_host *host,
> return NO_IRQ;
> }
> }
> - pr_debug("irq: -> obtained virq %d\n", virq);
>
> if (irq_setup_virq(host, virq, hwirq))
> return NO_IRQ;
>
> + printk(KERN_DEBUG "irq: irq %lu on host %s mapped to virtual irq %u\n",
> + hwirq, host->of_node ? host->of_node->full_name : "null", virq);
> +
Are you replacing the pr_debug because you want to drop the
DEBUG-dependency?
> return virq;
> }
> EXPORT_SYMBOL_GPL(irq_create_mapping);
> --
> 1.6.1.2
>
> _______________________________________________
> Linuxppc-dev mailing list
> Linuxppc-dev@ozlabs.org
> https://ozlabs.org/mailman/listinfo/linuxppc-dev
--
Pengutronix e.K. | Wolfram Sang |
Industrial Linux Solutions | http://www.pengutronix.de/ |
signature.asc
Description: Digital signature
_______________________________________________ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev
