On Sun, Mar 22, 2009 at 9:47 AM, Olof Johansson <o...@lixom.net> wrote: > On Sat, Mar 21, 2009 at 04:29:01PM -0600, Grant Likely wrote: >> From: Grant Likely <grant.lik...@secretlab.ca> >> >> This patch simplifies the driver by making use of more common code. > > Did you ever try building it? pasemi_defconfig gives me:
No. I mentioned it in the series header email, but not in the patch description. My 64bit build environment is broken at the moment so I couldn't build test the pasemi patch. All the others are build tested. I'll have it sorted out before I post v3. > drivers/net/pasemi_mac.c: In function 'pasemi_mac_phy_init': > drivers/net/pasemi_mac.c:1102: error: implicit declaration of function > 'of_phy_connect' > drivers/net/pasemi_mac.c:1103: warning: assignment makes pointer from integer > without a cast > drivers/net/pasemi_mac.c:1114: warning: label 'err' defined but not used > drivers/net/pasemi_mac.c:1092: warning: unused variable 'ret' > drivers/net/pasemi_mac.c:1091: warning: unused variable 'r' > drivers/net/pasemi_mac.c:1090: warning: unused variable 'prop' > drivers/net/pasemi_mac.c:1089: warning: unused variable 'ph' > make[2]: *** [drivers/net/pasemi_mac.o] Error 1 > > The changes needed are trivial, include <linux/of_mdio.h> and remove the > variables, label and following code. I could send a patch but that's likely > more of a hassle than you fixing it up yourself? Yeah, I'll fix it. Thanks for the testing. > Otherwise, with the above changes, seems to test out ok on my Electra. > When you checkin the changes, feel free to add: Awesome. Thanks for the testing. g. -- Grant Likely, B.Sc., P.Eng. Secret Lab Technologies Ltd. _______________________________________________ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev
