On Wed, 2009-03-11 at 14:53 +1100, Benjamin Herrenschmidt wrote: > This patch tweaks the way some PTE bit combinations are defined, in such a > way that the 32 and 64-bit variant become almost identical and that will > make it easier to bring in a new common pte-* file for the new variant > of the Book3-E support. > <snip> > +/* Permission masks used to generate the __P and __S table, > + * > + * Note:__pgprot is defined in arch/powerpc/include/asm/page.h > + */ > +#define PAGE_NONE __pgprot(_PAGE_BASE) > +#define PAGE_SHARED __pgprot(_PAGE_BASE | _PAGE_USER | _PAGE_RW) > +#define PAGE_SHARED_X __pgprot(_PAGE_BASE | _PAGE_USER | _PAGE_RW | > _PAGE_EXEC) > #define PAGE_COPY __pgprot(_PAGE_BASE | _PAGE_USER) > #define PAGE_COPY_X __pgprot(_PAGE_BASE | _PAGE_USER | _PAGE_EXEC) > #define PAGE_READONLY __pgprot(_PAGE_BASE | _PAGE_USER) > #define PAGE_READONLY_X __pgprot(_PAGE_BASE | _PAGE_USER | _PAGE_EXEC) > -#define PAGE_KERNEL __pgprot(_PAGE_BASE | _PAGE_WRENABLE) > -#define PAGE_KERNEL_CI __pgprot(_PAGE_PRESENT | _PAGE_ACCESSED | \ > - _PAGE_WRENABLE | _PAGE_NO_CACHE | _PAGE_GUARDED) > -#define PAGE_KERNEL_EXEC __pgprot(_PAGE_BASE | _PAGE_WRENABLE | _PAGE_EXEC)
Generic code needs PAGE_KERNEL_EXEC: mm/vmalloc.c: #ifndef PAGE_KERNEL_EXEC # define PAGE_KERNEL_EXEC PAGE_KERNEL #endif Not having it breaks modules because we don't map the text executable. cheers -- Michael Ellerman OzLabs, IBM Australia Development Lab wwweb: http://michael.ellerman.id.au phone: +61 2 6212 1183 (tie line 70 21183) We do not inherit the earth from our ancestors, we borrow it from our children. - S.M.A.R.T Person
signature.asc
Description: This is a digitally signed message part
_______________________________________________ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev
