On Fri, Mar 6, 2009 at 1:46 PM, Jens Axboe <jens.ax...@oracle.com> wrote: > On Fri, Mar 06 2009, Grant Likely wrote: >> > The SystemACE driver does not handle an empty CF slot gracefully. An >> > empty CF slot ends up hanging the system. This patch adds a check for >> > the CF state and stops trying to process requests if the slot is empty. > > So with patches like this, it's always nice to know what your target is. > Do you want this in .29, or just queued up for .30? It's not always easy > to judge the urgency of such patches :-)
The driver completely falls down and hangs the system if the CF slot is empty, so I would like to get it into .29. On the other hand, it has been a long standing issue, so if merging it will raise any eyebrows then I'm okay to wait for .30. > Also, I note that you are using end_request() throughout the driver. We > really want to get away from that, you should be using blk_end_request() > as that will handle full requests and not just segment-by-segment. No > worries for this patch, but you may want to consider that for a future > patch. Okay, will do. Thanks, g. -- Grant Likely, B.Sc., P.Eng. Secret Lab Technologies Ltd. _______________________________________________ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev
