On Tue, 3 Feb 2009, Josh Boyer wrote: > On Mon, Feb 02, 2009 at 11:24:18AM +1100, Benjamin Herrenschmidt wrote: > >The PCI 2.x cells used on some 44x SoCs only let us configure the decode > >for the low 32-bit of the incoming PLB addresses. The top 4 bits (this > >is a 36-bit bus) are hard wired to different values depending on the > >specific SoC in use. Our code used to work "by accident" until I added > >support for the ISA memory holes and while at it added more validity > >checking of the addresses. > > > >This patch should bring it back to working condition. It still relies > >on the device-tree being correct but that's somewhat a pre-requisite > >for anything to work anyway. > > > >Signed-off-by: Benjamin Herrenschmidt <b...@kernel.crashing.org> > >--- > > > >This is untested. Geert, can you give it a go on Sequoia and let me > >know if it fixes your problem ? > > Since Geert tested it somewhat successfully, perhaps we should get > this one into 2.6.29. I have no other fixes outstanding, so feel > free to pull it in yourself. > > Acked-by: Josh Boyer <jwbo...@linux.vnet.ibm.com>
Indeed, can we please get it in 2.6.29? (I know you wanted the original breakage into 2.6.28 as a last minute "fix" --- fortunately that didn't happen ---, but that doesn't mean we shouldn't fix the breakage for 2.6.29 :-) With kind regards, Geert Uytterhoeven Software Architect Sony Techsoft Centre Europe The Corporate Village · Da Vincilaan 7-D1 · B-1935 Zaventem · Belgium Phone: +32 (0)2 700 8453 Fax: +32 (0)2 700 8622 E-mail: geert.uytterhoe...@sonycom.com Internet: http://www.sony-europe.com/ A division of Sony Europe (Belgium) N.V. VAT BE 0413.825.160 · RPR Brussels Fortis · BIC GEBABEBB · IBAN BE41293037680010 _______________________________________________ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev
