On Fri, Jan 30, 2009 at 01:11:50PM +1100, Benjamin Herrenschmidt wrote: > > > This is trivially solved by converting arch/powerpc/sysdev/ipic.c > > back to spinlocks (ipic_lock). > > > > Assuming that converting-back is automatic, there are few other > > chained interrupt controllers you might want to convert-back: > > > > arch/powerpc/sysdev/i8259.c (i8259_lock) > > arch/powerpc/sysdev/mpic.c (mpic_lock) > > arch/powerpc/sysdev/qe_lib/qe_ic.c (qe_ic_lock) > > Except that a bunch of those can be both primary and chained...
Yeah, thanks for correcting. > It's > simply not a solution to have to "convert" interrupt controller code to > use a different locking scheme depending on whether they are chained or > primary... Actually, it doesn't matter whether a controller is a root IC or cascaded. Just as primary handlers, chained handlers don't run in threads, thus spinlocks should be used, not sleeping locks. -- Anton Vorontsov email: cbouatmai...@gmail.com irc://irc.freenode.net/bd2 _______________________________________________ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev
