On Thursday 22 January 2009, Anton Vorontsov wrote:
> This patch adds a new driver: sdhci-of. The driver is similar to
> the sdhci-pci, it contains common probe code, and controller-specific
> ops and quirks.
> 
> So far there are only Freescale eSDHC ops and quirks.

Looks very good overall.

Acked-by: Arnd Bergmann <a...@arndb.de>

> +     ret = of_address_to_resource(np, 0, &mem);
> +     if (ret)
> +             goto err_no_addr;
> +
> +     host->ioaddr = ioremap(mem.start, resource_size(&mem));
> +     if (!host->ioaddr) {
> +             ret = -ENOMEM;
> +             goto err_addr_map;
> +     }

Minor improvement: you could use of_iomap to do this in one step.

        Arnd <><
_______________________________________________
Linuxppc-dev mailing list
Linuxppc-dev@ozlabs.org
https://ozlabs.org/mailman/listinfo/linuxppc-dev

Reply via email to