On Tue, 20 Jan 2009, Roel Kluin wrote: > >> make id signed so a negative id will get noticed > > > > Thanks for noticing! It looks OK, except... > > > 1. You forgot to update the forward declaration of ps3av_set_video_mode() in > > arch/powerpc/include/asm/ps3av.h (did you compile this succesfully?) > > fixed that (and no, sorry, I didn't compile test it, I have to focus a bit on > a biotechnology exam, maybe later). > > > 2. You forgot to change `u32 id' in ps3av_probe(). > > ok, changed it. but I am not sure whether the last two hunks are ok. Should > we error out like this or just let the negative value be assigned to > ps3av->ps3av_mode? If not, is there more cleanup required?
I'll look into it and will take further care of it... > > > Can you please make these changes, too? Thx again! > > No problem. > > --------------------->8-------------------------8<------------------------ > Make id signed so a negative id will get noticed. Error out if > ps3av_auto_videomode() fails. Thanks again! With kind regards, Geert Uytterhoeven Software Architect Sony Techsoft Centre Europe The Corporate Village · Da Vincilaan 7-D1 · B-1935 Zaventem · Belgium Phone: +32 (0)2 700 8453 Fax: +32 (0)2 700 8622 E-mail: geert.uytterhoe...@sonycom.com Internet: http://www.sony-europe.com/ A division of Sony Europe (Belgium) N.V. VAT BE 0413.825.160 · RPR Brussels Fortis · BIC GEBABEBB · IBAN BE41293037680010 _______________________________________________ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev
