On Tue, Jan 13, 2009 at 03:43:55AM +0300, Yuri Tikhonov wrote:
> Adds the platform device definitions and the architecture specific support
> routines for the ppc440spe adma driver.
>
> Any board equipped with PPC440SP(e) controller may utilize this driver.
>
> diff --git a/arch/powerpc/boot/dts/katmai.dts
> b/arch/powerpc/boot/dts/katmai.dts
> index 077819b..f2f77c8 100644
> --- a/arch/powerpc/boot/dts/katmai.dts
> +++ b/arch/powerpc/boot/dts/katmai.dts
> @@ -16,7 +16,7 @@
>
> / {
> #address-cells = <2>;
> - #size-cells = <1>;
> + #size-cells = <2>;
You've changed the root level size-cells, but haven't updated the
sub-nodes (such as /memory) accordingly.
> model = "amcc,katmai";
> compatible = "amcc,katmai";
> dcr-parent = <&{/cpus/c...@0}>;
> @@ -392,6 +392,30 @@
> 0x0 0x0 0x0 0x3 &UIC3 0xa 0x4 /* swizzled int C
> */
> 0x0 0x0 0x0 0x4 &UIC3 0xb 0x4 /* swizzled int D
> */>;
> };
> + DMA0: dma0 {
No 'compatible' property, which seems dubious.
> + interrupt-parent = <&DMA0>;
> + interrupts = <0 1>;
> + #interrupt-cells = <1>;
> + #address-cells = <0>;
> + #size-cells = <0>;
> + interrupt-map = <
> + 0 &UIC0 0x14 4
> + 1 &UIC1 0x16 4>;
> + };
> + DMA1: dma1 {
> + interrupt-parent = <&DMA1>;
> + interrupts = <0 1>;
> + #interrupt-cells = <1>;
> + #address-cells = <0>;
> + #size-cells = <0>;
> + interrupt-map = <
> + 0 &UIC0 0x16 4
> + 1 &UIC1 0x16 4>;
Are these interrupt-maps correct? The second interrupt from both dma
controllers is routed to the same line on UIC1?
> + };
> + xor {
> + interrupt-parent = <&UIC1>;
> + interrupts = <0x1f 4>;
What the hell is this thing? No compatible property, nor even a
meaningful name.
> + };
> };
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
_______________________________________________
Linuxppc-dev mailing list
Linuxppc-dev@ozlabs.org
https://ozlabs.org/mailman/listinfo/linuxppc-dev
