On Wed, Jan 7, 2009 at 8:20 AM, Gerhard Pircher <gerhard_pirc...@gmx.net> wrote: > > -------- Original-Nachricht -------- >> Datum: Wed, 7 Jan 2009 08:07:14 -0700 >> Von: "Grant Likely" <grant.lik...@secretlab.ca> >> An: "Gerhard Pircher" <gerhard_pirc...@gmx.net> >> CC: linuxppc-dev@ozlabs.org >> Betreff: Re: [PATCH 3/5] powerpc: Bootwrapper and serial console support for >> AmigaOne > >> On Wed, Jan 7, 2009 at 7:03 AM, Gerhard Pircher <gerhard_pirc...@gmx.net> >> wrote: >> > diff --git a/arch/powerpc/boot/serial.c b/arch/powerpc/boot/serial.c >> > index 8b3607c..f2156f0 100644 >> > --- a/arch/powerpc/boot/serial.c >> > +++ b/arch/powerpc/boot/serial.c >> > @@ -117,7 +117,8 @@ int serial_console_init(void) >> > if (devp == NULL) >> > goto err_out; >> > >> > - if (dt_is_compatible(devp, "ns16550")) >> > + if (dt_is_compatible(devp, "ns16550") || >> > + dt_is_compatible(devp, "pnpPNP,501")) >> > rc = ns16550_console_init(devp, &serial_cd); >> >> Why not just claim "ns16550" compatibility in the device tree node? > It was suggested that I should use PNP identifiers for all ISA devices, as > these are part of a real PCI2ISA bridge (when I sent the previous version > or these patches).
Okay, I just read that thread. Hmmm... I'm not fond of it but it is an established convention and I cannot fault you for it. g. -- Grant Likely, B.Sc., P.Eng. Secret Lab Technologies Ltd. _______________________________________________ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev
