On Dec 17, 2008, at 9:41 AM, Anton Vorontsov wrote:
On Wed, Dec 03, 2008 at 10:27:38PM +0300, Anton Vorontsov wrote:
With this API we're able to set a QE pin to the GPIO mode or a
dedicated
peripheral function.
The API relies on the fact that QE gpio controllers are registered.
If
they aren't, the API won't work (gracefully though).
There is one caveat though: if anybody occupied the node->data
before us,
or overwrote it, then bad things will happen. Luckily this is all
in the
platform code that we fully control, so this should never happen.
I could implement more checks (for example we could create a list of
successfully registered QE controllers, and compare the node->data
in the
qe_pin_request()), but this is unneeded if nobody is going to do
silly
things behind our back.
Signed-off-by: Anton Vorontsov <avoront...@ru.mvista.com>
---
Kumar, can you please merge this patch? It is the last patch that
holds the FHCI USB driver.
Thanks,
Will do. Can I get you to add kdoc comments for the API functions:
+extern struct qe_pin *qe_pin_request(struct device_node *np, int
index);
+extern void qe_pin_free(struct qe_pin *qe_pin);
+extern void qe_pin_set_gpio(struct qe_pin *qe_pin);
+extern void qe_pin_set_dedicated(struct qe_pin *pin);
- k
_______________________________________________
Linuxppc-dev mailing list
Linuxppc-dev@ozlabs.org
https://ozlabs.org/mailman/listinfo/linuxppc-dev
