On Sat, 2008-12-13 at 17:33 -0600, Kumar Gala wrote: > An example calling sequence which we did see: > > copy_user_highpage -> kmap_atomic -> flush_tlb_page -> _tlbil_va > > We got interrupted after setting up the MAS registers before the > tlbwe and the interrupt handler that caused the interrupt also did > a kmap_atomic (ide code) and thus on returning from the interrupt > the MAS registers no longer contained the proper values. > > Since we dont save/restore MAS registers for normal interrupts we > need to disable interrupts in _tlbil_va to ensure atomicity. > > Signed-off-by: Kumar Gala <ga...@kernel.crashing.org>
Acked-by: Benjamin Herrenschmidt <b...@kernel.crashing.org> --- Paul, this is a 2.6.28 regression, it should probably go to Linus in case he hasn't released yet :-) Cheers, Ben. _______________________________________________ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev