Hi Nathan,

On Wed, 10 Dec 2008 18:46:05 -0600 Nathan Lynch <[EMAIL PROTECTED]> wrote:
>
> @@ -418,13 +416,7 @@ static struct device_node *cpu_to_l2cache(int cpu)
>       if (np == NULL)
>               return NULL;
>  
> -     php = of_get_property(np, "l2-cache", NULL);
> -     if (php == NULL)
> -             return NULL;
> -     ph = *php;
> -     of_node_put(np);
> -
> -     return of_find_node_by_phandle(ph);
> +     return of_find_next_cache_node(np);
>  }

This leaks a reference on np ...

-- 
Cheers,
Stephen Rothwell                    [EMAIL PROTECTED]
http://www.canb.auug.org.au/~sfr/

Attachment: pgp8w5ZUWyPvX.pgp
Description: PGP signature

_______________________________________________
Linuxppc-dev mailing list
Linuxppc-dev@ozlabs.org
https://ozlabs.org/mailman/listinfo/linuxppc-dev

Reply via email to