On Thu, Nov 27, 2008 at 11:40:55AM -0500, Jon Smirl wrote:
> > + if (port->irq == NO_IRQ) {
> > + dev_err(&op->dev, "Could not get irq\n");
> > + return -ENODEV;
> > + }
>
> Doesn't NO_IRQ imply polling, not an error?
See below, I just copied the original behaviour. Having another look at
mpc52xx_uart_setup, I don't see any polling option there, so I think it
is correct to do this.
>
> >
> > dev_dbg(&op->dev, "mpc52xx-psc uart at %p, irq=%x, freq=%i\n",
> > (void *)port->mapbase, port->irq, port->uartclk);
> >
> > - if ((port->irq == NO_IRQ) || !port->mapbase) {
> > - printk(KERN_ERR "Could not allocate resources for PSC\n");
> > - return -EINVAL;
> > - }
(Originaly dropout for NO_IRQ)
Regards,
Wolfram
--
Dipl.-Ing. Wolfram Sang | http://www.pengutronix.de
Pengutronix - Linux Solutions for Science and Industry
signature.asc
Description: Digital signature
_______________________________________________ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev
