Trent Piepho writes: > > Alternatively you could add a new function (called, for instance, > > of_get_gpio_flags) with the extra parameter to eliminate the need to > > change any drivers at this stage, since they all seem to pass NULL for > > the flags argument. > > But if we did this every time any exported function needs to change, think > how bloated the API would be with cruft.
I don't buy the argument that we can't add one thing because if we added a hundred that would be too much. You could add of_get_gpio_flags, get that upstream, then get the driver patches upstream, then submit a patch to remove of_get_gpio. Alternatively you could make of_get_gpio a macro or inline function in of_gpio.h. If you really want to change everything in one hit you'll have to get acks + agreement for the change to go upstream via my tree from all the relevant driver maintainers first. I don't see any particular advantage to doing it that way, though. Paul. _______________________________________________ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev
