On Tue, 17 Nov 2026 12:10:12 +0100
Pierre Gondois <[email protected]> wrote:

> Add support for CPER Memory Error Section 2 through MCE, allowing
> to emit an mce_record trace event. The implementation follows
> the existing CPER Memory Error Section (1) implementation.
> 
> Fix the mismatch between the parameter definition/declaration
> of apei_mce_report_mem_error().

Do that separately.  Trivial but shouldn't be buried in a patch
doing anything else.

Otherwise seems fine to me but I'll defer to x86 folk on whether
this is the approach they prefer.

With the trivial change split out, for both of them.
Reviewed-by: Jonathan Cameron <[email protected]>

> 
> Signed-off-by: Pierre Gondois <[email protected]>

> diff --git a/drivers/acpi/apei/ghes.c b/drivers/acpi/apei/ghes.c
> index 07306af5a54b9..703f3b7f700a6 100644
> --- a/drivers/acpi/apei/ghes.c
> +++ b/drivers/acpi/apei/ghes.c
> @@ -1030,6 +1030,7 @@ static void ghes_do_proc(struct ghes *ghes,
>                       }
>  
>                       atomic_notifier_call_chain(&ghes_report_mem2_chain, 
> sev, mem_err);
> +                     arch_apei_report_mem_error2(sev, mem_err);
>                       queued |= ghes_handle_memory_failure2(gdata, sev, sync);
>               } else if (guid_equal(sec_type, &CPER_SEC_PCIE)) {
>                       ghes_handle_aer(gdata);
> diff --git a/include/acpi/apei.h b/include/acpi/apei.h
> index dc60f7db5524f..a92174793d9c2 100644
> --- a/include/acpi/apei.h
> +++ b/include/acpi/apei.h
> @@ -52,6 +52,7 @@ int erst_clear(u64 record_id);
>  
>  int arch_apei_enable_cmcff(struct acpi_hest_header *hest_hdr, void *data);
>  void arch_apei_report_mem_error(int sev, struct cper_sec_mem_err *mem_err);
> +void arch_apei_report_mem_error2(int sev, struct cper_sec_mem_err2 *mem_err);
>  
>  #endif
>  #endif


Reply via email to