On Nov 16, 2008, at 2:26 PM, Benjamin Herrenschmidt wrote:

On Sun, 2008-11-16 at 15:43 -0600, Milton Miller wrote:
Instead of copying current_set[cpu] to secondary_ti, directly index into
current_set by the cpu number like head_64.S.  In addition to removing
the variable, a slow to respond cpu will not clobber another cpus
stack.

Except that we don't know our CPU number at this stage do we ? IE. r24
is our HW number, is it guaranteed to be what we want to index
current_set ?

No, you are right, current_set is ordered by logical cpu id.

We could search the hwcpuid array similar to our search of the paca on ppc64. But for now go ahead and reject this patch.

milton

_______________________________________________
Linuxppc-dev mailing list
Linuxppc-dev@ozlabs.org
https://ozlabs.org/mailman/listinfo/linuxppc-dev

Reply via email to