On Tue, Nov 10, 2026 at 3:59 PM <[email protected]> wrote: > > From: bui duc phuc <[email protected]> > > fsl_sai_read_dlcfg() returns errors from of_property_read_u32_index() > without reporting them. > > Add a dev_err() call in fsl_sai_probe() to report failures returned > by fsl_sai_read_dlcfg(). > > Signed-off-by: bui duc phuc <[email protected]>
Reviewed-by: Shengjiu Wang <[email protected]> Best regards Shengjiu Wang > --- > sound/soc/fsl/fsl_sai.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/sound/soc/fsl/fsl_sai.c b/sound/soc/fsl/fsl_sai.c > index 59c9b8c28133..16197f9ac2d8 100644 > --- a/sound/soc/fsl/fsl_sai.c > +++ b/sound/soc/fsl/fsl_sai.c > @@ -1621,8 +1621,10 @@ static int fsl_sai_probe(struct platform_device *pdev) > > /* read dataline mask for rx and tx*/ > ret = fsl_sai_read_dlcfg(sai); > - if (ret < 0) > + if (ret < 0) { > + dev_err(dev, "failed to read dlcfg %d\n", ret); > return ret; > + } > > irq = platform_get_irq(pdev, 0); > if (irq < 0) > -- > 2.43.0 >
