On Wed, 2008-11-05 at 22:34 +1100, Paul Mackerras wrote: > Benjamin Herrenschmidt writes: > > > The pseries PCI Hotplug code has a number of issues, ranging from > > incorrect resource setup to crashes, depending on what is added, > > when, whether it contains a bridge, etc etc.... > > > > This patch fixes a whole bunch of these, while actually simplifying > > the code a bit, using more generic code in the process and factoring > > out common code between adding of a PHB, a slot or a device. > > This causes a compile error on Cell: > > arch/powerpc/kernel/of_platform.c: In function 'of_pci_phb_probe': > arch/powerpc/kernel/of_platform.c:287: error: implicit declaration of > function 'pcibios_claim_one_bus' > make[2]: *** [arch/powerpc/kernel/of_platform.o] Error 1
Ah right, cell +/- uses the hotplug PCI stuff to probe it's PHB, a bit strange I admit. Probably have to take that out of CONFIG_HOTPLUG. Ben. _______________________________________________ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev