Stop using [p4d|pud|pmd]_ERROR() in __get_pte_phys() as the pgtable entries
are known to be NULL and hence could not really be accessed.

Cc: Yoshinori Sato <[email protected]>
Cc: Rich Felker <[email protected]>
Cc: John Paul Adrian Glaubitz <[email protected]>
Cc: [email protected]
Cc: [email protected]
Reviewed-by: David Hildenbrand (Arm) <[email protected]>
Signed-off-by: Anshuman Khandual <[email protected]>
---
Changes in RFC V3

- Added some pr_error() messages in __get_pte_phys()

 arch/sh/mm/init.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/arch/sh/mm/init.c b/arch/sh/mm/init.c
index 9466ae6f9f16..8d65e60688dc 100644
--- a/arch/sh/mm/init.c
+++ b/arch/sh/mm/init.c
@@ -59,19 +59,19 @@ static pte_t *__get_pte_phys(unsigned long addr)
 
        p4d = p4d_alloc(NULL, pgd, addr);
        if (unlikely(!p4d)) {
-               p4d_ERROR(*p4d);
+               pr_err("allocating p4d table failed\n");
                return NULL;
        }
 
        pud = pud_alloc(NULL, p4d, addr);
        if (unlikely(!pud)) {
-               pud_ERROR(*pud);
+               pr_err("allocating pud table failed\n");
                return NULL;
        }
 
        pmd = pmd_alloc(NULL, pud, addr);
        if (unlikely(!pmd)) {
-               pmd_ERROR(*pmd);
+               pr_err("allocating pmd table failed\n");
                return NULL;
        }
 
-- 
2.43.0


Reply via email to