On Fri, Oct 24, 2008 at 3:41 PM, Anton Vorontsov <[EMAIL PROTECTED]> wrote: > On Fri, Oct 24, 2008 at 12:59:00PM -0700, John Linn wrote: >> diff --git a/drivers/gpio/Kconfig b/drivers/gpio/Kconfig >> index 7f2ee27..f6b0da8 100644 >> --- a/drivers/gpio/Kconfig >> +++ b/drivers/gpio/Kconfig >> @@ -65,6 +65,14 @@ config GPIO_SYSFS >> >> # put expanders in the right section, in alphabetical order >> >> +comment "Memory mapped GPIO expanders:" >> + >> +config GPIO_XILINX >> + bool "Xilinx GPIO support" >> + depends on OF > > I persume that the driver wasn't build-tested on SPARC, so I'd recommend > to change the depends to PPC_OF. Plus, the driver should also select > GENERIC_GPIO and ARCH_REQUIRE_GPIOLIB. (Later we'll switch to > ARCH_WANT_OPTIONAL_GPIOLIB for whole PPC.)
ARCH_WANT_OPTIONAL_GPIOLIB seems to already be set for all of powerpc (arch/powerpc/Kconfig, line 113). But, since this is a cross-arch driver living in drivers/gpio the dependencies work the other way around. This driver cannot be selected unless GPIOLIB is turned on. g. -- Grant Likely, B.Sc., P.Eng. Secret Lab Technologies Ltd. _______________________________________________ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev
