The gadget device name is set by UDC core when registering the gadget
and must not be set before to avoid leaking the name in intermediate
error paths (e.g. when detecting an older chip revision).

Fixes: 12ad0fcaf2fb ("usb: gadget: amd5536udc: let udc-core manage gadget->dev")
Cc: [email protected]      # 3.10
Signed-off-by: Johan Hovold <[email protected]>
---
 drivers/usb/gadget/udc/snps_udc_core.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/usb/gadget/udc/snps_udc_core.c 
b/drivers/usb/gadget/udc/snps_udc_core.c
index 0e0db68e0b27..d506f9d92bca 100644
--- a/drivers/usb/gadget/udc/snps_udc_core.c
+++ b/drivers/usb/gadget/udc/snps_udc_core.c
@@ -3133,7 +3133,6 @@ int udc_probe(struct udc *dev)
        /* device struct setup */
        dev->gadget.ops = &udc_ops;
 
-       dev_set_name(&dev->gadget.dev, "gadget");
        dev->gadget.name = name;
        dev->gadget.max_speed = USB_SPEED_HIGH;
 
-- 
2.53.0


Reply via email to